Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed num gpus missing arg for ddp compatibility #660

Merged
merged 2 commits into from
Jan 29, 2023
Merged

fixed num gpus missing arg for ddp compatibility #660

merged 2 commits into from
Jan 29, 2023

Conversation

shaydeci
Copy link
Contributor

No description provided.

@dagshub
Copy link

dagshub bot commented Jan 29, 2023

Join the discussion on DagsHub!

@shaydeci shaydeci marked this pull request as ready for review January 29, 2023 10:33
@shaydeci shaydeci requested a review from ofrimasad as a code owner January 29, 2023 10:33
ofrimasad
ofrimasad approved these changes Jan 29, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 353b7d1 into master Jan 29, 2023
@ofrimasad ofrimasad deleted the bug/SG-000_fix_regent_recipe_for_ddp branch January 29, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaydeci @ofrimasad